[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 04:01:14 PDT 2022


aaron.ballman added inline comments.


================
Comment at: clang/test/Lexer/utf8-char-literal.cpp:16
 char f = u8'ab'; // expected-error {{Unicode character literals may not contain multiple characters}}
 #elif __STDC_VERSION__ > 202000L
 char a = u8'ñ';      // expected-error {{character too large for enclosing character literal type}}
----------------
I missed this one before. :-(


================
Comment at: clang/test/Lexer/utf8-char-literal.cpp:31
+/// Test u8 char literal preprocessor behavior
+#if __cplusplus > 201402L || __STDC_VERSION__ > 202000L
+#if u8'\xff' != 0xff
----------------
Uh oh.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124996/new/

https://reviews.llvm.org/D124996



More information about the cfe-commits mailing list