[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 14:26:52 PDT 2022


zixuw created this revision.
zixuw added reviewers: ributzka, dang, cishida.
Herald added a project: All.
zixuw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Reapply the change after fixing sanitizer errors.
The original problem was that `StringRef`s in `Matches` are pointing to
temporary local `std::string`s created by `path::convert_to_slash` in
the regex match call. This patch does the conversion up front in
container `FilePath`.

This reverts commit 2966f0fa505266735dbc8324b8821b7f0aa901ff <https://reviews.llvm.org/rG2966f0fa505266735dbc8324b8821b7f0aa901ff>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124964

Files:
  clang/include/clang/ExtractAPI/FrontendActions.h
  clang/lib/ExtractAPI/ExtractAPIConsumer.cpp
  clang/test/ExtractAPI/known_files_only_hmap.c
  clang/test/ExtractAPI/relative_include.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124964.427138.patch
Type: text/x-patch
Size: 19265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220504/84c640fe/attachment-0001.bin>


More information about the cfe-commits mailing list