[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

OK, so wanting this to be utility makes sense, and maybe/probably it should be the default.

I'm still concerned some users will find this a large regression and we won't have a good workaround:

- it'll use a lot more battery than before
- not everyone will see the background index as so critical
- I think our only advice can be to disable background indexing entirely

What do you think about keeping `Background` in the enum along with `Low`, and switching clangd to `Low`?
I'm happy to do the plumbing to add a flag to clangd, and to implement `Low` for other OSes.
(Digging into windows, it looks like the background mode there is also much slower).

@kadircet any opinion here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124715/new/

https://reviews.llvm.org/D124715