[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 11:37:30 PDT 2022


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!

In D124666#3490871 <https://reviews.llvm.org/D124666#3490871>, @frederic-tingaud-sonarsource wrote:

> By the way, in the current state of the code, there is no risk of such conflict between typo correction and UnqualifiedBase, because when an unqualified base exists the lookup result will not be empty.
> That's why the test was not failing even without moving the compatibility first.

Yep, that's exactly it, but with the reordering it's somewhat clearer that, if we make this work for MS compat purposes, typo correction will not occur.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124666/new/

https://reviews.llvm.org/D124666



More information about the cfe-commits mailing list