[PATCH] D124669: [flang][driver] Add support for -save-temps

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski marked 4 inline comments as done.
awarzynski added inline comments.


================
Comment at: flang/test/Driver/fno-integrated-as.f90:18
+! DEFAULT-LABEL: "-fc1"
+! DEFAULT-SAME: "-o" "fno-integrated-as.o" "{{.*}}fno-integrated-as.f90"
----------------
rovka wrote:
> Nit (here and above): Is it a rule that `-o blah` comes right before the input file, or should we also add a {{.*}} in between in case other flags sneak in?
> Nit (here and above): Is it a rule that -o blah comes right before the input file, or should we also add a {{.*}} in between in case other flags sneak in?

TBH, it's not something that I checked, but it's been the case so far :) We may need to insert `{{.*}}` there at some point, but perhaps lets delay until it's really needed? This way we will know exactly what violates that rule and perhaps we could tweak then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124669/new/

https://reviews.llvm.org/D124669