[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev accepted this revision.
sgatev added a comment.

Looks great! Thank you!



================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1156
+// FIXME: Remove this test once it provides no additional test coverage.
+TEST_F(FlowConditionTest, DoesNotAssertForImplicitCastToBool) {
+  std::string Code = R"(
----------------
Maybe call this `PointerToBoolImplicitCast` and remove the FIXME?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124807/new/

https://reviews.llvm.org/D124807