[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

[Eric Li via Phabricator via cfe-commits]

li.zhe.hua updated this revision to Diff 426985.
li.zhe.hua marked 7 inline comments as done.
li.zhe.hua added a comment.

Add `ExprWithCleanups` requirement to `createStorageLocation`, `setStorageLocation`, and `getStorageLocation`.
Remove `ParenExpr` requirement from `getValue`.
Remove unnecessary calls to `IgnoreParens`.
Address misc. comments; apply suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124807/new/

https://reviews.llvm.org/D124807

Files:
  clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h
  clang/include/clang/Analysis/FlowSensitive/Transfer.h
  clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
  clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp
  clang/lib/Analysis/FlowSensitive/Transfer.cpp
  clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
  clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124807.426985.patch
Type: text/x-patch
Size: 10592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220504/0b20651e/attachment-0001.bin>