[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

[Ken Matsui via Phabricator via cfe-commits]

ken-matsui added a comment.

@aaron.ballman

> If so, I think putting Diag after the call of this function would be better.

With the above change, I tried to add comments to failed tests, but there were over 300 files.

During my investigation, I found most tests printed warnings without file information strangely.

  error: 'warning' diagnostics seen but not expected: 
    Line 0: this style of line directive is a GNU extension
    Line 0: this style of line directive is a GNU extension
  2 errors generated.

If warnings have file information, it should be like:

  error: 'warning' diagnostics seen but not expected: 
    File /tmp/llvm-project/clang/test/Preprocessor/line-directive.c Line 9: this style of line directive is a GNU extension
  1 error generated.

Even tests that completely do not use preprocessor directives, such as `clang/test/SemaCXX/matrix-type.cpp`, failed with the above strange warnings.

Thus, I suspect that the warnings without file paths have come from internally included SDK (I'm using macOS that includes `/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk`) or something that is not related to target test files.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124534/new/

https://reviews.llvm.org/D124534