[PATCH] D124736: [CodeGen] Use ABI alignment for placement new

Daniel Bertalan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 10:36:44 PDT 2022


BertalanD added a comment.

In D124736#3485128 <https://reviews.llvm.org/D124736#3485128>, @rjmccall wrote:

> It should probably be the ABI alignment in all cases; I think the preferred alignment is just supposed to be used to opportunistically over-align things like e.g. local variables, which doesn't seem relevant for the ABI code involving a call to `operator new`.

Right, that makes sense. I'll update this patch tomorrow. Thanks for the review :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124736/new/

https://reviews.llvm.org/D124736



More information about the cfe-commits mailing list