[PATCH] D123831: [clang][extract-api] Use relative includes

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 08:53:09 PDT 2022


dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.

Minor comment LGTM otherwise



================
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:203
+    // Try to reduce the include name the same way we tried to include it.
+    if (auto IncludeName = getRelativeIncludeName(CI, FileName))
+      if (llvm::find(KnownFiles, *IncludeName) != KnownFiles.end()) {
----------------
Should we be tracking if the include was quoted or not? In principle, that could mean a different redirect in header search and therefore potentially mapping to different content.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123831/new/

https://reviews.llvm.org/D123831



More information about the cfe-commits mailing list