[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski marked 8 inline comments as done.
awarzynski added a comment.

Thanks for the review @rovka!



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:86
+
+  // ... otherwise, generate an MLIR module from the input Fortran source
   bool res = RunPrescan() && RunParse() && RunSemanticChecks();
----------------
rovka wrote:
> Nit: Should we assert that the language is Language::Fortran at this point?
No harm in doing so 👍 !


================
Comment at: flang/test/Driver/emit-asm-from-llvm-bc.ll:9
+;-------------
+; RUN: rm -f %t.bc
+; RUN: %flang_fc1 -emit-llvm-bc %s -o %t.bc
----------------
rovka wrote:
> Have you tried %basename_t.bc instead? You might be able to skip all the `rm`s then...
IIUC, the only difference between `%t.bc`and ` %basename_t.bc`  is that former contains a directory name and the file extension and latter does not. In either case, LIT won't delete it :(

I like %t a bit more as this way we make sure that the output lands in the right temporary directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124667/new/

https://reviews.llvm.org/D124667