[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

Stefan Gränitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 3 05:02:43 PDT 2022


sgraenitz added a comment.

Thanks for your help! I will work on testing in calendar week 21.



================
Comment at: llvm/lib/CodeGen/WinEHPrepare.cpp:966
 
-        if (FuncletBundleOperand == FuncletPad)
+        if (!FuncletPad || FuncletBundleOperand == FuncletPad)
           continue;
----------------
rnk wrote:
> Is this change necessary? It seems like it shouldn't be after the clang and preisel pass changes.
Yes, apparently it is necessary. There are cases, where `CodeGenFunction::getBundlesForFunclet()` registers a "funclet" bundle operand, but the `FuncletPad` here is null. My guess was it might be due to optimizations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124762/new/

https://reviews.llvm.org/D124762



More information about the cfe-commits mailing list