[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

Mon May 2 13:06:13 PDT 2022

vit9696 added a comment.

In D124767#3486286 <https://reviews.llvm.org/D124767#3486286>, @keith wrote:

> Based on the issue it sounds like this should be gated behind a new `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to apply to it as well, similar to the others. And we'll definitely want some tests here!

For tests, sure. I will add some once there is general agreement on the option.

As for the new flag, I am confused. To me the timeline is as follows:

- LLVM implemented `-fprofile-prefix-map.
- GCC implemented `-fprofile-prefix-map`.
- LLVM renamed `-fprofile-prefix-map` to `-fcoverage-prefix-map`.
- GCC preliminary agreed to extend `-fprofile-prefix-map` with gcda path mapping.
- This patch implements this extension to LLVM `-fcoverage-prefix-map`, which remains being renamed `-fprofile-prefix-map`.

Do I misunderstand something? These flags are rather confusing in their semantics.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124767/new/

https://reviews.llvm.org/D124767