[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 08:57:03 PDT 2022


dblaikie added a comment.

Would an explicit naming be more suitable than a region start/end? (I'd have considered this feedback for D116503 <https://reviews.llvm.org/D116503> too, but didn't catch that one in review) The region based thing makes non-positional arguments weirdly positional (not that these are the first instances of that in compiler/linker tools, I don't think) - and I guess the override behavior is already positional to some degree.

But something like -Wno-unused-command-line-argument=-Wfoobarbaz -Wfoobarbaz - sort of like password entry, type it twice so you've got less chance of mistakes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121175/new/

https://reviews.llvm.org/D121175



More information about the cfe-commits mailing list