[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

Tobias Ribizel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 2 06:04:24 PDT 2022


upsj added inline comments.


================
Comment at: clang-tools-extra/clangd/Preamble.cpp:167
+            // ... whose template parameter comes from the function directly
+            if (FT->getTemplateParameters()->getDepth() ==
+                PackTypePtr->getDepth()) {
----------------
Can PackTypePtr ever be nullptr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124688/new/

https://reviews.llvm.org/D124688



More information about the cfe-commits mailing list