[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 1 11:07:17 PDT 2022
LegalizeAdulthood added a comment.
Testing on VTK revealed this change:
- this->SliceMapper->SetBackground((this->Background &&
- !(this->SliceFacesCamera && this->InternalResampleToScreenPixels &&
- !this->SeparateWindowLevelOperation)));
+ this->SliceMapper->SetBackground(
+ (this->Background &&
+ (!this->SliceFacesCamera && this->InternalResampleToScreenPixels ||
+ this->SeparateWindowLevelOperation)));
Which is incorrect. So more improvement is needed for the case of `!(x && y && !z)` or `!(x || y || !z)` is encountered.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124650/new/
https://reviews.llvm.org/D124650
More information about the cfe-commits
mailing list