[clang] 9f7ac52 - [OpenMP] Fix printing commands twice in verbose mode

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 29 20:06:44 PDT 2022


Author: Joseph Huber
Date: 2022-04-29T23:06:22-04:00
New Revision: 9f7ac522ae1cacd954e12f89cd4f3d049251188e

URL: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e
DIFF: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e.diff

LOG: [OpenMP] Fix printing commands twice in verbose mode

Summary:
A previous patch merged the command execution and printing into a helper
function. The old printing code wasn't removed causing each to be
printed twice.

Added: 
    

Modified: 
    clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index c2c1fa738be6..4ed303fa233f 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -638,9 +638,6 @@ Expected<std::string> assemble(StringRef InputFile, Triple TheTriple,
 
   CmdArgs.push_back(InputFile);
 
-  if (Verbose)
-    printCommands(CmdArgs);
-
   if (Error Err = executeCommands(*PtxasPath, CmdArgs))
     return std::move(Err);
 
@@ -678,9 +675,6 @@ Expected<std::string> link(ArrayRef<std::string> InputFiles, Triple TheTriple,
   for (StringRef Input : InputFiles)
     CmdArgs.push_back(Input);
 
-  if (Verbose)
-    printCommands(CmdArgs);
-
   if (Error Err = executeCommands(*NvlinkPath, CmdArgs))
     return std::move(Err);
 
@@ -716,9 +710,6 @@ Expected<std::string> link(ArrayRef<std::string> InputFiles, Triple TheTriple,
   for (StringRef Input : InputFiles)
     CmdArgs.push_back(Input);
 
-  if (Verbose)
-    printCommands(CmdArgs);
-
   if (Error Err = executeCommands(*LLDPath, CmdArgs))
     return std::move(Err);
 
@@ -796,9 +787,6 @@ Expected<std::string> link(ArrayRef<std::string> InputFiles, Triple TheTriple,
   for (StringRef Input : InputFiles)
     CmdArgs.push_back(Input);
 
-  if (Verbose)
-    printCommands(CmdArgs);
-
   if (Error Err = executeCommands(LinkerUserPath, CmdArgs))
     return std::move(Err);
 


        


More information about the cfe-commits mailing list