[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

[Kirill Stoimenov via Phabricator via cfe-commits]

kstoimenov added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558
+  TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*");
+  EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning));
+  // And we can explicitly exclude a category too.
----------------
This breaks sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/22933. 

Could you please fix or revert? 


```
/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558
Value of: *TU.build().getDiagnostics()
Expected: has 1 element that (Diag at 1:16-1:19 = [unused function 'foo']) and (diag name "-Wunused-function") and (diag source 1) and (diag severity 3)
  Actual: { [1:16-1:19] unused function 'foo', [1:16-1:19] declaration must be declared within the '__llvm_libc' namespace }, which has 2 elements
/b/sanitizer-x86_64-linux-fast/build/llvm-project/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:562
Value of: *TU.build().getDiagnostics()
Expected: is empty
  Actual: { [1:16-1:19] declaration must be declared within the '__llvm_libc' namespace }, whose size is 1

```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124679/new/

https://reviews.llvm.org/D124679