[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 29 13:56:35 PDT 2022


LegalizeAdulthood added a comment.

In D124650#3481514 <https://reviews.llvm.org/D124650#3481514>, @LegalizeAdulthood wrote:

> General question:
>
> There is the question of whether or not the replacement should have `()`s around the whole
> thing because we don't analyze the context to see if the change in precedence between
> `operator!` and `operator&&` or `operator||` makes any difference.

I suppose it's better to be safe than sorry, so I'll update the check to surround the replacement
with parens.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124650/new/

https://reviews.llvm.org/D124650



More information about the cfe-commits mailing list