[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

Fri Apr 29 10:05:48 PDT 2022

aaron.ballman added a comment.

In D122895#3482707 <https://reviews.llvm.org/D122895#3482707>, @manojgupta wrote:

>   Is disabling the pedantic warning an option for your users?
>
> Disabling it wholesale is not an option since they actually want this warning  (the older version). But we agreed to disable it specifically for the code where the warning was getting fired.
> One instance is https://review.coreboot.org/c/coreboot/+/63936 .
>
> I have been fixing our codebase to clean this and clean the instances. But it takes a lot of time and effort. Plus it takes a long time to clean one failure before I can find others  (public CLs) https://chromium-review.googlesource.com/q/Wstrict-prototypes+owner:manojgupta

Out of curiosity, are you using K&R C functions in your code base (definitions with an identifier list or a declaration with empty parens)? Basically, I'm wondering if you'd be able to enable `-fno-knr-function`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122895/new/

https://reviews.llvm.org/D122895