[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 29 05:15:32 PDT 2022


aaron.ballman added a comment.

In D124434#3480915 <https://reviews.llvm.org/D124434#3480915>, @dblaikie wrote:

> I guess coming back to your other point about restructing the way all this testing works (be a pity to gate the default change on this work as it sounds like a big project) - yeah, it'd be nice to be able to declare a test as "language version neutral" or "in this version and above" (or, I guess "only in these versions and no others") - and have some mode in the lit build that can then handle running it in all known versions - and maybe the developer default could be "run in the most recent shipped version only" for speed (if the speed is noticable) and leave it to buildbots to run in all the language versions.

Yeah, that's basically what I was envisioning; it may make build bots slower, but any expansion of test coverage leads to that outcome, so I don't see it as being a bad thing so long as we keep the developer experience reasonable. We might want to do something on the build bots to help folks know "to reproduce, you may need to run lit with this extra parameter so all tests are run" or some other marker to help folks who break a buildbot know what's going on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124434/new/

https://reviews.llvm.org/D124434



More information about the cfe-commits mailing list