[PATCH] D119296: KCFI sanitizer

[Joao Moreira via Phabricator via cfe-commits]

joaomoreira added a comment.

> I agree that a separate pass wasn't ideal, but InstCombine seems to be full of code to "fix what other passes messed up".  :)  I'm not sure if messed up is the correct term though, these are checks that were necessary before optimizations, but are no longer needed.

Pardon my lack of vocabulary, I didn't mean it in a disrespectful way -- what I meant is that having a third pass to get things in optimal shape because other passes moved stuff around seems to be not ideal, or at least less ideal than having a single pass that only puts things in their places once all the rest was already moved around.

It doesn't sound unreal to me thinking about a backend pass that could also move things around and still break the instrumentation after it is reparable, but this is hypothetical at this point as nothing comes to mind right away, so I won't push this button.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296