[PATCH] D124211: Add __builtin_call_kcfi_unchecked

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

Can you link to the lore thread on discussions around the builtin?



================
Comment at: clang/lib/Sema/SemaChecking.cpp:436
+
+  auto Call = dyn_cast_or_null<CallExpr>(BuiltinCall->getArg(0));
+
----------------
`auto *Call =`
https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto


================
Comment at: clang/lib/Sema/SemaChecking.cpp:451
+
+  auto Builtin = S.ImpCastExprToType(BuiltinCall->getCallee()->IgnoreImpCasts(),
+                                     S.Context.getPointerType(BuiltinTy),
----------------
`auto *Builtin =`

though I would perhaps not use `auto` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124211/new/

https://reviews.llvm.org/D124211