[PATCH] D123325: [Clang] Make enabling the new driver more generic
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 28 11:03:21 PDT 2022
tra added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2535-2538
+def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group<Action_Group>,
+ HelpText<"Use the new driver for offloading compilation.">;
+def fno_offload_new_driver : Flag<["-"], "fno-offload-new-driver">, Flags<[CC1Option]>, Group<Action_Group>,
+ HelpText<"Don't Use the new driver for offloading compilation.">;
Nit: Can we combine that into a `BoolFOption` instead of using `Flag` ?
Also, considering that it's an option which controls the driver's behavior, not just tweaks code generation, perhaps it should be just `--[no]offload-new-driver`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits