[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 09:30:15 PDT 2022


hubert.reinterpretcast added a comment.

In D124556#3480228 <https://reviews.llvm.org/D124556#3480228>, @ken-matsui wrote:

> @hubert.reinterpretcast
>
> Sorry, I'm a newbie here, but is there anything I should do after getting approved?

I'm not sure if the instructions are a bit out-of-date: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

If you intend to contribute going forward, the idea would be to get a few patches approved and committed on your behalf and then to request commit access. Until you have commit access, you will need to ask people on the review to help you commit.

I can commit this patch for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124556/new/

https://reviews.llvm.org/D124556



More information about the cfe-commits mailing list