[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 07:30:06 PDT 2022


hubert.reinterpretcast added a comment.

In D124556#3479833 <https://reviews.llvm.org/D124556#3479833>, @ken-matsui wrote:

> @hubert.reinterpretcast,
>
> Sorry to have missed providing a summary.

You can still provide one by using the "Edit Revision" link.

I suggest something like:
Prevents confusion over which `S` is referenced in the final `else` branch if such a use is added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124556/new/

https://reviews.llvm.org/D124556



More information about the cfe-commits mailing list