[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 06:19:28 PDT 2022

aaron.ballman added a comment.

In D122920#3479884 <https://reviews.llvm.org/D122920#3479884>, @erichkeane wrote:

> In D122920#3479192 <https://reviews.llvm.org/D122920#3479192>, @yihanaa wrote:
>>> While we'd usually be happy to take the fix-in-hand and apply it, part of the discussion on the other thread is whether to remove `__builtin_dump_struct` entirely. Because of that, I don't think we should make substantial changes in this area until it's clear we're keeping the builtin.
>> Thanks for take a look, I agree to wait for the outcome of the discussion
> I think I disagree with Aaron.  While, YES, we are likely to delete this in the near future, it doesn't mean we should leave it in a broken state in the meantime.  WHILE all of this is likely to be deleted, it has value until we delete it.

I'm not opposed to moving forward with this check, I just didn't want @yihanaa (and reviewers) to spend time working on this if it's going to be removed in this release of Clang anyway.

Comment at: clang/test/CodeGen/dump-struct-builtin.c:809
\ No newline at end of file

You should add the newline back to the end of the test.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list