[PATCH] D124606: Use `binary` git attribute instead of `text eol=...'

Michael Forster via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 03:58:51 PDT 2022


MForster created this revision.
MForster added a reviewer: labath.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
MForster requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

These automatic conversions lead to issues in various workflows, and all
we want here are files that retain their line endings under all
circumstances. `binary` captures that perfectly well and leads to fewer
issues.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124606

Files:
  clang-tools-extra/test/.gitattributes


Index: clang-tools-extra/test/.gitattributes
===================================================================
--- clang-tools-extra/test/.gitattributes
+++ clang-tools-extra/test/.gitattributes
@@ -4,12 +4,12 @@
 
 # These test input files rely on one-byte Unix (LF) line-endings, as they use
 # fixed -offset, FileOffset:, or Offset: numbers in their tests.
-clang-apply-replacements/ClangRenameClassReplacements.cpp text eol=lf
-clang-apply-replacements/Inputs/basic/basic.h text eol=lf
-clang-apply-replacements/Inputs/format/no.cpp text eol=lf
-clang-apply-replacements/Inputs/format/yes.cpp text eol=lf
-clang-tidy/infrastructure/export-diagnostics.cpp text eol=lf
+clang-apply-replacements/ClangRenameClassReplacements.cpp binary
+clang-apply-replacements/Inputs/basic/basic.h binary
+clang-apply-replacements/Inputs/format/no.cpp binary
+clang-apply-replacements/Inputs/format/yes.cpp binary
+clang-tidy/infrastructure/export-diagnostics.cpp binary
 
 # These test input files rely on two-byte Windows (CRLF) line endings.
-clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf
-clang-apply-replacements/Inputs/crlf/crlf.cpp.expected text eol=crlf
+clang-apply-replacements/Inputs/crlf/crlf.cpp binary
+clang-apply-replacements/Inputs/crlf/crlf.cpp.expected binary


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124606.425741.patch
Type: text/x-patch
Size: 1281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220428/359ddd48/attachment-0001.bin>


More information about the cfe-commits mailing list