[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added a comment.

LGTM in general, with some suggestions in-line. Besides those, I think we should be able to remove `PPSkipMappings` from the condition in `MinimizedVFSFile::create` (`DependencyScanningFilesystem.cpp`).



================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:207
       // skipping in the preprocessor.
       if (PPSkipMappings)
         ScanInstance.getPreprocessorOpts()
----------------
I think we can remove this check as well now.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:291
 
-  if (Service.canSkipExcludedPPRanges())
-    PPSkipMappings =
-        std::make_unique<ExcludedPreprocessorDirectiveSkipMapping>();
+  PPSkipMappings = std::make_unique<ExcludedPreprocessorDirectiveSkipMapping>();
   if (Service.getMode() == ScanningMode::MinimizedSourcePreprocessing)
----------------
Do we need to keep this on the heap?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124558/new/

https://reviews.llvm.org/D124558