[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 27 16:38:13 PDT 2022
aaronpuchert added a comment.
Most of the files changed here are not affected by the `.gitattributes` file, such as
The only affected files seem to be
Looking back at D97625 <https://reviews.llvm.org/D97625>, the main goal of that change was to ensure that tests relying on LF endings also work on Windows, and the two files that want CRLF did not in fact cause test failures.
So maybe we should simply remove
# These test input files rely on two-byte Windows (CRLF) line endings.
clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf
clang-apply-replacements/Inputs/crlf/crlf.cpp.expected text eol=crlf
from the `.gitattributes` file again. Then we can keep them stored with CRLF endings, and each file has a comment anyway that they rely on them. The files have been there for many years and never been a problem.
Could you test if this works for you?
We can still discuss normalizing the other files, but maybe we can get some reviewers involved in `clang-tools-extra` for that.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits