[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 27 11:50:05 PDT 2022


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681
+                                 ArgStringList &CmdArgs) const {
+  CmdArgs.push_back(
+      Args.MakeArgString(StringRef("-L") + RocmInstallation.getLibPath()));
----------------
Nit: `CmdArgs.append({ ... })` to add all arguments at once would be a bit more readable (no `CmdArgs.push_back` littering space between args).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124545/new/

https://reviews.llvm.org/D124545



More information about the cfe-commits mailing list