[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Due to how expensive it is to instantiate all the templates from ASTMatchers.h, we typically don't add new matchers unless there's a need for them in-tree or they're expected to be generally useful to a number of out-of-tree matchers. Are you planning to make use of these matchers for a clang-tidy check you're working on or something along those lines? Or are they mostly to add missing coverage?

On the technical side (feel free to ignore this until we know we're going to add the matchers to Clang if you'd like), you should add test coverage for the new matchers to clang/unittests/ASTMatchers and you should regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124373/new/

https://reviews.llvm.org/D124373