[PATCH] D124493: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

[Filipe Cabecinhas via Phabricator via cfe-commits]

filcab added a comment.

Hi @hctim, thanks for the patch.
I have one question, though. Do you really need to remove the information you removed?
Some people might be testing ASan binaries without access to debug info (because it's been stripped or it's not been loaded and is not available for the sanitizers to get symbols from, etc), and having the full global information would be useful for those reports.

Can this be done by having a flag to make clang not emit the source information + the sanitizer patch to get the line and column?
That way we could keep the current behaviour of emitting more info, and you'd still get your savings + use of debuginfo.

Thank you,
Filipe


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124493/new/

https://reviews.llvm.org/D124493