[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

Wed Apr 27 07:23:43 PDT 2022

nemanjai added inline comments.

================
Comment at: clang/docs/ClangCommandLineReference.rst:3566

+Control the CR-bit tracking feature on PowerPC. ``-mcrbits`` (the enablement of CR-bit tracking support) is the default for POWER8 and above.
+
----------------
```
... is the default for POWER8 and above as well as for all other CPUs when optimization is applied (-O2 and above).
```
But please check if it is also applied at -O1 and correct that statement accordingly.

================
Comment at: llvm/test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:5
 ; CHECK-LABEL: TestULT:
-; CHECK: xscmpudp
+; CHECK: fcmpu
 ; CHECK: blr
----------------
Why do we not emit the VSX instructions here any longer? How are crbits related?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124060/new/

https://reviews.llvm.org/D124060