[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

Wed Apr 27 00:16:35 PDT 2022

njames93 added a comment.

In D124341#3475083 <https://reviews.llvm.org/D124341#3475083>, @aaron.ballman wrote:

> I went through the changes and they look correct to me... yet I'm still mildly terrified. :-D Have you tried running clang-tidy through its paces with ASan/MSan enabled to see if the change introduces any use-after-free issues in practice?

I can't seem to build LLVM with msan at all. But ASan, which checks things like use after free, ran all clang tools tests without a hitch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124341/new/

https://reviews.llvm.org/D124341