[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.
ChenZheng via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 26 23:44:34 PDT 2022
shchenz accepted this revision as: shchenz.
shchenz added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing.
Comment at: clang/lib/Basic/Targets/PPC.cpp:519
+ Features["crbits"] = llvm::StringSwitch<bool>(CPU)
+ .Case("ppc64le", true)
> shchenz wrote:
> > If we set the `+crbits` by the arch name, do we still need the customization (Turn on crbits for O2 and above) in `computeFSAdditions()`?
> Yeah, that's a good point. I looked into this previously, and it appears that addition of `-mcrbits` inside `computeFSAdditions()` may still be necessary.
> In particular, we have test cases that test pre-POWER8 with optimizations on (or, if no optimization level is provided, then -O2 is assumed the default). In these cases, much of the code changes if the customization inside `computeFSAdditions()` is removed because we would no longer be using crbits pre-P8.
hmm, OK, then we still have the same issue that this patch fixes for pre-POWER8. I'm ok with leaving it for now as IMO Power7/Power6 should not be major versions for PowerPC.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits