[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

[Dan Liew via Phabricator via cfe-commits]

delcypher added a comment.

> I'd definitely prefer moving towards LLVM_ENABLE_RUNTIMES. We already require LLVM_ENABLE_RUNTIMES for libc++, libc++abi and libunwind and I'm going to propose doing the same for compiler-rt as well.

+1 on this. Compiler-RT's CMake code is extremely and unnecessarily complicated because we support far too many exotic build configurations.

> I don't want to roadblock or say "no we absolutely can't let this in", _but_... Apple Clang and Swift have long been the only reason we've kept this code alive. I didn't have the time to fix Apple Clang years ago, and nobody has made the effort since.

I'm going to approve because this change seems reasonable. However, I think we need to have a serious conversation about removing `LLVM_BUILD_EXTERNAL_COMPILER_RT` with an actual deadline so that we can make forward progress here. This review is probably the wrong place to have that discussion. We probably should have an RFC on the forums with the deprecation plan.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124474/new/

https://reviews.llvm.org/D124474