[PATCH] D124487: [HLSL] Adjust access specifier behavior

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 16:51:29 PDT 2022


beanz created this revision.
beanz added reviewers: aaron.ballman, MaskRay, kuhar, rsmith.
Herald added subscribers: Anastasia, StephenFan.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

HLSL doesn't support access specifiers. This change has two components:

1. Make default access for classes public
2. Diagnose the use of access specifiers as a clang HLSL extension

As long as the default behavior for access specifiers matches HLSL,
allowing them to be used doesn't cause sourece incompatability with
valid code. As such enabling them as a clang extension seems like a
reasonable approach.

Fixes #55124


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124487

Files:
  clang/include/clang/Basic/DiagnosticParseKinds.td
  clang/lib/Parse/ParseDeclCXX.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/ParserHLSL/access_specifiers.hlsl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124487.425342.patch
Type: text/x-patch
Size: 3942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220426/136deacf/attachment.bin>


More information about the cfe-commits mailing list