[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 16:46:57 PDT 2022


dgoldman created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

- Use the expression's type for non-C++ as the variable type. This works well, but might not preserve the typedefs due to type canonicalization.

- Improve support for Objective-C property references which are represented using `ObjCPropertyRefExpr` and `BuiltinType::PseudoObject`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124486

Files:
  clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp
  clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124486.425340.patch
Type: text/x-patch
Size: 7886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220426/46740093/attachment-0001.bin>


More information about the cfe-commits mailing list