[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

Tue Apr 26 14:07:01 PDT 2022

phosek added a comment.

In D124474#3475550 <https://reviews.llvm.org/D124474#3475550>, @beanz wrote:

> In D124474#3475539 <https://reviews.llvm.org/D124474#3475539>, @azharudd wrote:
>
>> In this case I'm just trying to make it work with existing build configurations where it is being used (for example Swift). We should definitely be moving away from `LLVM_BUILD_EXTERNAL_COMPILER_RT` in favor of `LLVM_ENABLE_RUNTIMES` eventually though.
>
> My point here is that maybe you should move away from the legacy way of building now rather than improving it... Not sure how @phosek feels about this. I would personally very much prefer if we only had one way to build compiler-rt instead of the half dozen we have today.

I'd definitely prefer moving towards `LLVM_ENABLE_RUNTIMES`. We already require `LLVM_ENABLE_RUNTIMES` for libc++, libc++abi and libunwind and I'm going to propose doing the same for compiler-rt as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124474/new/

https://reviews.llvm.org/D124474