[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON
Azharuddin Mohammed via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 26 14:02:38 PDT 2022
azharudd added a comment.
In D124474#3475432 <https://reviews.llvm.org/D124474#3475432>, @beanz wrote:
> I question whether we should be extending this or killing it off... Is there a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of `LLVM_ENABLE_RUNTIMES=compiler-rt`?
In this case I'm just trying to make it work with existing build configurations where it is being used (for example Swift). We should definitely be moving away from `LLVM_BUILD_EXTERNAL_COMPILER_RT` in favor of `LLVM_ENABLE_RUNTIMES` eventually though.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits