[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

Konrad Wilhelm Kleine via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 12:01:15 PDT 2022


kwk added a comment.

In D121370#3471183 <https://reviews.llvm.org/D121370#3471183>, @krasimir wrote:

> It appears that this regressed include sorting in the following case, where the contents of `test.h` show the expected include order and the `clang-format` behavior before this patch:
>
>   % cat test.h
>   #include <cstdint>
>   
>   #include "util/bar.h"
>   #include "util/foo/foo.h"  // foo<T>
>   % bin/clang-format --version; bin/clang-format -style=google test.h
>   clang-format version 15.0.0 (https://github.com/llvm/llvm-project.git d46fa023caa2db5a9f1e21dd038bcb626261d958)
>   #include "util/foo/foo.h"  // foo<T>
>   #include <cstdint>
>   
>   #include "util/bar.h"
>
> @kwk could you please take a look

@krasimir I'm on sick leave and will have a look as soon as I'm back. Can it wait that long?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121370/new/

https://reviews.llvm.org/D121370



More information about the cfe-commits mailing list