[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 09:44:31 PDT 2022


dblaikie added a comment.

In D123436#3462567 <https://reviews.llvm.org/D123436#3462567>, @dblaikie wrote:

> Perhaps GlobalModuleIndex should create the cursor itself - it's being handed the buffer anyway?

Ping on this ^ - would this be a better direction that addresses the concerns?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123436/new/

https://reviews.llvm.org/D123436



More information about the cfe-commits mailing list