[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 09:24:36 PDT 2022


Meinersbur added a comment.

In D118409#3474131 <https://reviews.llvm.org/D118409#3474131>, @kiranchandramohan wrote:

> I think the CI is complaining about some clang-format issue in  clang/test/OpenMP/critical_codegen_attr.cpp

clang-format should not be applied on Clang tests, many of them have significant whitespace (eg. the preprocessor tests). In this case, all that clang-format suggests is

  diff --git a/clang/test/OpenMP/critical_codegen.cpp b/clang/test/OpenMP/critical_codegen.cpp
  index 41454b6dd1b4..d472325ff8a2 100644
  --- a/clang/test/OpenMP/critical_codegen.cpp
  +++ b/clang/test/OpenMP/critical_codegen.cpp
  @@ -22,7 +22,10 @@
  -void foo() { extern void mayThrow(); mayThrow(); }
  +void foo() {
  +  extern void mayThrow();
  +  mayThrow();
  +}

These lines were not changed in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118409/new/

https://reviews.llvm.org/D118409



More information about the cfe-commits mailing list