[PATCH] D119544: Deferred Concept Instantiation Implementation

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 08:10:11 PDT 2022


erichkeane added a comment.

I found



================
Comment at: clang/test/SemaTemplate/concepts.cpp:386-388
+  []()
+    requires(constraint<decltype(Local)>)
+  {}();
----------------
erichkeane wrote:
> ChuanqiXu wrote:
> > We might need more negative tests.
> > Now it would pass even if I write:
> > ```
> > []()
> >     requires(false)
> > {}();
> > ```
> Ouch!  I'll have to see if I can find where we're missing that check!
Well, I fixed most of the OTHER stuff I think by setting up the context properly (see incoming patch!), but this ends up failing crashing, as does a few other things in this test.  Still looking through it, but want to get you the latest.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119544/new/

https://reviews.llvm.org/D119544



More information about the cfe-commits mailing list