[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

Tue Apr 26 08:06:12 PDT 2022

sgatev marked an inline comment as done.
sgatev added a comment.

In D124395#3474597 <https://reviews.llvm.org/D124395#3474597>, @ymandel wrote:

> Nice work. On the surface, this adds complexity to the system and so should be justified in terms of performance improvements. However, having read through the patch, I think it overall reduces the complexity, since both environment join and boolean-value join have been radically simplified.  So, I'm fine with the patch as is, even without performance measurement. That said, I'm not against such measurement -- just saying it's not blocking. :)
>
> If you agree, you may want to reword the description of the patch to focuse on the design improvements rather than (exclusively) the optimization aspect.

Agreed. I updated the description.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124395/new/

https://reviews.llvm.org/D124395