[PATCH] D124384: [clang] Fix a constant evaluator crash on a NULL-type expr.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D124384#3471917 <https://reviews.llvm.org/D124384#3471917>, @sammccall wrote:

> This is a reasonable immediate fix, but creating null-typed expressions that live *outside* the recoveryexpr seems scary, and likely to violate expected invariants elsewhere too...

Yeah, the fundamental issue is that we create a null-typed expression (`ParenListExpr`) outside a template context, which is similar to our prior case where we have a dependent expression outside a template context. Perhaps it violates invariants in other places as well, but this is the first time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124384/new/

https://reviews.llvm.org/D124384