[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 00:21:25 PDT 2022


junaire updated this revision to Diff 425134.
junaire added a comment.

use std::move().

I'm not sure this will be better but hope it will make others happy :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123436/new/

https://reviews.llvm.org/D123436

Files:
  clang/lib/Serialization/GlobalModuleIndex.cpp


Index: clang/lib/Serialization/GlobalModuleIndex.cpp
===================================================================
--- clang/lib/Serialization/GlobalModuleIndex.cpp
+++ clang/lib/Serialization/GlobalModuleIndex.cpp
@@ -277,7 +277,7 @@
       return std::make_pair(nullptr, Res.takeError());
   }
 
-  return std::make_pair(new GlobalModuleIndex(std::move(Buffer), Cursor),
+  return std::make_pair(new GlobalModuleIndex(std::move(Buffer), std::move(Cursor)),
                         llvm::Error::success());
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123436.425134.patch
Type: text/x-patch
Size: 520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220426/5523a695/attachment.bin>


More information about the cfe-commits mailing list