[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

liushuai wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 21:01:48 PDT 2022


MTC added inline comments.


================
Comment at: clang/include/clang/Tooling/Refactoring/AtomicChange.h:119
 
+  Replacements &getRefReplacements() { return Replaces; }
+
----------------
IMHO, there is no need to rename the method to get the non-const version.  The following code is ok enough

`Replacements &getReplacements() { return Replaces; }`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123924/new/

https://reviews.llvm.org/D123924



More information about the cfe-commits mailing list