[PATCH] D124382: [Clang] Recognize target address space in superset calculation

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

You should be able to provide an address space of the pointer using the number, see details in:
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Builtins.def#L65

However if language address spaces are needed I wonder if the best approach is just to extend
the Builtin definitions with language address spaces similar to other qualifiers?

> This patch attempts to find a happy medium between not recognising target
>  address spaces at all (current state) and allowing all uses of it, based on
>  the assumption that users must know better. What it does not to is to
>  provide a bidirectional translation mechanism, which I'm not sure could ever
>  be done, with the current address space implementation (use of 0, the value
>  of default, etc).

Can you provide an example of where it could be useful? Note that I feel that
such functionality could be implemented on top of full implementation of
target specific address space proposed in https://reviews.llvm.org/D62574.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124382/new/

https://reviews.llvm.org/D124382